Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: vgo overwrites version in go.mod file (e.g. v1 by v1.0.0) #24036

Closed
kuba-- opened this issue Feb 22, 2018 · 2 comments

Comments

@kuba--
Copy link

commented Feb 22, 2018

What version of Go are you using (go version)?

go version go1.10 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOROOT="/usr/local/opt/go/libexec"
GOTOOLDIR="/usr/local/opt/go/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches -fno-common"

What did you do?

$ cat go.mod

module "github.com/kuba--/test"

require "gopkg.in/bufio.v1" v1

$ cat test.go

package main // import "github.com/kuba--/test"

import bufio "gopkg.in/bufio.v1"

func main() {
	_ := bufio.NewBufferString("test")
}

$ vgo build

vgo: finding gopkg.in/bufio.v1 v1.0.0
vgo: gopkg.in/bufio.v1 v1.0.0: unexpected status (https://api.github.com/repos/go-bufio/bufio/git/refs/tags/v1.0.0): 404 Not Found
vgo: finding gopkg.in/bufio.v1 v1.0.0
vgo: gopkg.in/bufio.v1 v1.0.0: unexpected status (https://api.github.com/repos/go-bufio/bufio/git/refs/tags/v1.0.0): 404 Not Found
vgo: unexpected status (https://api.github.com/repos/go-bufio/bufio/git/refs/tags/v1.0.0): 404 Not Found

$ cat go.mod

module "github.com/kuba--/test"

require "gopkg.in/bufio.v1" v1.0.0

What did you expect to see?

vgo overwrote version (replaced v1 by v1.0.0) that's why got 404 (https://api.github.com/repos/go-bufio/bufio/git/refs/tags/v1.0.0). Link https://api.github.com/repos/go-bufio/bufio/git/refs/tags/v1 works fine.

@gopherbot gopherbot added this to the vgo milestone Feb 22, 2018

@zeebo

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

See also #24024

@rsc

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2018

Duplicate of #24476.

@rsc rsc closed this Mar 30, 2018

@golang golang locked and limited conversation to collaborators Mar 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.