Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: Support optional fall back to "legacy" command line calls to git, bzr, hg, etc #24048

Closed
timshannon opened this issue Feb 22, 2018 · 4 comments

Comments

@timshannon
Copy link

commented Feb 22, 2018

This may not be possible with the possible changes to $GOPATH handing in vgo, but if there was a flag or environment variable you could set to fall back to the old method of calling the git / bzr / hg executables, then it might allow for workarounds for issues like #24044 or for any case where you are hosting your instance of gitea gogs, etc.

It might also allow for a work around for the rate limiting issues in #23955.

@gopherbot gopherbot added this to the vgo milestone Feb 22, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Feb 22, 2018

Elsewhere I believe @rsc said that it was a design mistake to have the "go" command directly call the git/bzr/hg/svn executables, because that effectively requires either 1) all users to have all 4 tools installed, or 2) force the ecosystem to all use the same tool (e.g. git, like today). Good luck being a Go user wanting to put your source code up on the Internet with bzr. The ecosystem will be annoyed.

@timshannon

This comment has been minimized.

Copy link
Author

commented Feb 22, 2018

True, and I complete agree with that going forward, however, having an optional flag / variable could ease the transition until suitable long-term workaround are in place for the scenarios referenced.

@andrewchambers

This comment has been minimized.

Copy link

commented Feb 23, 2018

Since we now embrace versions, we can also embrace version tarballs. lots of those tools can dynamically generate a tarball url for a given tag.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2018

We're not going to fall back to the legacy version control tools, for the reasons Brad mentioned (also at https://research.swtch.com/vgo-module).

That said, I would be happy to support version control servers that are willing to speak simple HTTPS REST APIs to tell vgo what it needs to know (pretty basic queries plus fetch me a specific file or a tgz/zip at a given commit). I haven't looked into which ones do that.

Rest assured that we will find some way to make it easy to use local servers. We know the whole world isn't on GitHub.

@rsc rsc closed this Mar 30, 2018

@golang golang locked and limited conversation to collaborators Mar 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.