Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: security of requiring github token #24055

Closed
docmerlin opened this issue Feb 23, 2018 · 1 comment
Closed

x/vgo: security of requiring github token #24055

docmerlin opened this issue Feb 23, 2018 · 1 comment
Milestone

Comments

@docmerlin
Copy link

@docmerlin docmerlin commented Feb 23, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

vgo

Does this issue reproduce with the latest release?

No, just with vgo.

Github oauth scopes do not exist such that you can read from multiple github repos, including private repos without also granting write permission for those repos. This is a security concern for automated build environments.

@gopherbot gopherbot added this to the vgo milestone Feb 23, 2018
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Mar 27, 2018

For the case of private repos, assuming they're in an organization, you could make a CI account that only has read permission to the repos.

Beyond that, sure, it would be great if GitHub supported read-only oauth scopes. If so, vgo would happily use that token (it doesn't check which scopes are associated with the token).

I'd love suggestions about what to do instead of the current github token but that seems to be the best github is offering right now. If you know of something different we can do, I'd be happy to listen.

@rsc rsc closed this Mar 27, 2018
@golang golang locked and limited conversation to collaborators Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.