Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: verify should ignore not-yet-downloaded dependencies #24067

Closed
rogpeppe opened this issue Feb 23, 2018 · 3 comments

Comments

@rogpeppe
Copy link
Contributor

commented Feb 23, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version devel +104445e Wed Feb 7 19:22:09 2018 +0000 linux/amd64 vgo:2018-02-20.1

What did you do?

% vgo build ./...
% vgo test ./...
ok etc
% vgo verify
vgo: resolving import "github.com/pkg/errors"
vgo: finding github.com/pkg/errors (latest)
vgo: adding github.com/pkg/errors v0.8.0
vgo: resolving import "launchpad.net/gocheck"
vgo: import "launchpad.net/gocheck": unknown VCS, Repo: bzr, 
https://launchpad.net/~niemeyer/gocheck/trunk

Ignoring the fact that vgo doesn't support bzr yet, it's arguably wrong that vgo verify verifies more than we've already chosen to depend on. I wished to verify my current build and its dependencies, but not necessarily the testing dependencies of those dependencies (which can be considerably more substantial, and might not be available).

I wasn't expecting verify to download or resolve any more dependencies than I'd already used.

@gopherbot gopherbot added this to the vgo milestone Feb 23, 2018

@rsc rsc changed the title x/vgo: verify command verifies tests in dependencies too x/vgo: verify should ignore not-yet-downloaded dependencies Mar 30, 2018

@rsc rsc added the NeedsFix label Mar 30, 2018

@oiooj

This comment has been minimized.

Copy link
Member

commented Apr 20, 2018

At https://github.com/golang/vgo/blob/master/vendor/cmd/go/internal/vgo/search.go#L165

Default level is levelTestRecursive .

Should we add an level argument for func AllPackages and func MatchPackages ? or use a global level var ? @rsc

@gopherbot

This comment has been minimized.

Copy link

commented May 13, 2018

Change https://golang.org/cl/112998 mentions this issue: cmd/go/internal/vgo: import packages at right level

@gopherbot

This comment has been minimized.

Copy link

commented Jun 11, 2018

Change https://golang.org/cl/117935 mentions this issue: cmd/go/internal/vgo: skip not-yet-downloaded module in verify

@golang golang locked and limited conversation to collaborators Jun 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.