Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: split codegen tests into files (one for each arch) #24077
Working on the file is slightly annoying because when writing, reading or grepping through it you can never tell inside which architecture's array you are, so I find myself constantly scrolling/jumping back in the file until I find the start of the array, where I can read the name of the variable that holds it and determine which architecture tests I'm looking at.
Reviewing changes to the file is also difficult, because a reviewer will need to expand potentially hundreds of unchanged lines in the diff just to be sure that a new test is being added to the rigth array.
I propose we split the tests into files, one for each architecture. We can keep