-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/review/git-codereview: do not mail CLs with editor temp files, binaries #24139
Comments
How about disallowing non-printable characters in commit messages too? For example, see https://go-review.googlesource.com/c/go/+/97635, which shows on my terminal as:
|
OK sure do that too. |
What kind of binaries should it disallow? We have repositories with images, for instance. update: I created a patch for the case of temp editor files and non-printable characters. |
Change https://golang.org/cl/101755 mentions this issue: |
"mail" command rejects *~, #*# and .#* filenames. Also it should reject commit messages with non-printable characters, because these are impossible to spot in the review. For golang/go#24139 Change-Id: I3544e3c34c5ac9f55a7808264de4535bc455bd0a Reviewed-on: https://go-review.googlesource.com/101755 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
Motivated by #23800, git-codereview should probably refuse to mail CLs with editor temp files and binaries.
The text was updated successfully, but these errors were encountered: