Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: show detailed error when directory cannot be opened #24154

Closed
ysmolsky opened this issue Feb 27, 2018 · 1 comment
Closed
Milestone

Comments

@ysmolsky
Copy link
Member

@ysmolsky ysmolsky commented Feb 27, 2018

When goimports cannot some directory it does not tell me which directory is to blaim. It can lead to cumbersome debugging.

Instead of

% goimports -e main.go
2018/02/27 17:45:40 goimports: scanning directory /h/t/go/src: permission denied

I want to see

% goimports -e main.go
2018/02/27 17:45:40 goimports: scanning directory /h/t/go/src: permission denied while opening dir: /h/t/go/src/dir/denied

Refers to #16890 which is supposed to be full fix of the situation (do not exit from goimports in dir open error)

@gopherbot gopherbot added this to the Unreleased milestone Feb 27, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 27, 2018

Change https://golang.org/cl/97359 mentions this issue: x/tools/cmd/goimports: show detailed error when directory cannot be opened

@golang golang locked and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.