Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: confused by ./ imports #24157

Closed
neild opened this issue Feb 27, 2018 · 4 comments
Closed

x/vgo: confused by ./ imports #24157

neild opened this issue Feb 27, 2018 · 4 comments
Milestone

Comments

@neild
Copy link
Contributor

@neild neild commented Feb 27, 2018

When compiling a package containing import "./sub":

$ vgo build .
vgo: resolving import "./sub"
FindRepo: Get https://./sub?go-get=1: dial tcp: lookup .: no such host
vgo: import "github.com/neild/test" ->
	import "./sub": Get https://./sub?go-get=1: dial tcp: lookup .: no such host

I have no opinion on whether vgo should support relative imports, but it probably should at least recognize them.

@gopherbot gopherbot added this to the vgo milestone Feb 27, 2018
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Feb 27, 2018

Or this could be the chance to kill them.

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Feb 27, 2018

but it probably should at least recognize them.

Agreed. Enough to say "no", rather than tcp: lookup .: no such host

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Mar 27, 2018

They're definitely not supposed to work, but they're not supposed to fail that badly. :-)

(They don't work from within GOPATH today even with the standard go command.)

@rsc rsc added the NeedsFix label Mar 27, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 20, 2018

Change https://golang.org/cl/108378 mentions this issue: cmd/go/internal/vgo: vgo does not support relative imports

@golang golang locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.