Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net, x/crypto: CONTRIBUTING.md still says GitHub pull requests are not accepted #24185

Closed
mark-rushakoff opened this issue Mar 1, 2018 · 30 comments
Assignees
Milestone

Comments

@mark-rushakoff
Copy link
Contributor

@mark-rushakoff mark-rushakoff commented Mar 1, 2018

What did you do?

I opened a trivial pull request against golang.org/x/crypto, and gerritbot converted my PR to a CL as expected.

What did you expect to see?

CONTRIBUTING.md should not have said "We do not accept GitHub pull requests", but perhaps should have mentioned gerritbot.

What did you see instead?

We do not accept GitHub pull requests (we use Gerrit instead for code review).

I noticed the same message on x/net/CONTRIBUTING.md, but I did not check any other x/ repositories.

@gopherbot gopherbot added this to the Unreleased milestone Mar 1, 2018
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 1, 2018

/cc @andybons

@jlburkhead
Copy link

@jlburkhead jlburkhead commented Mar 8, 2018

Also found these in other golang org repos.

https://github.com/golang/gddo/blame/dcea65fd03382fd4f4df9ebdac117c6e0cde2594/CONTRIBUTING.md#L7
https://github.com/golang/oauth2/blame/2f32c3ac0fa4fb807a0fcefb0b6f2468a0d99bd0/CONTRIBUTING.md#L26
https://github.com/golang/review/blame/f5dbde0c1ab9393757674eb259f2de6e40f1a7b3/CONTRIBUTING.md#L26
https://github.com/golang/tools/blame/059bec968c61383b574810040ba9410712de36c5/CONTRIBUTING.md#L26
https://github.com/golang/blog/blame/bc40a4c35d3ac1807d228e6fabee47ff3ff81cae/CONTRIBUTING.md#L26
https://github.com/golang/crypto/blame/85f98707c97e11569271e4d9b3d397e079c4f4d0/CONTRIBUTING.md#L26
https://github.com/golang/exp/blame/83bc9a11ae1a00a79c4e59fc5d965d21fe14e6bb/CONTRIBUTING.md#L26
https://github.com/golang/image/blame/12117c17ca67ffa1ce22e9409f3b0b0a93ac08c7/CONTRIBUTING.md#L26
https://github.com/golang/mobile/blame/70bad68322f4b891e6b4081ab040469b793a9d4a/CONTRIBUTING.md#L26
https://github.com/golang/net/blame/07e8617a6db2368fa55d4616f371ee1b1403c817/CONTRIBUTING.md#L26
https://github.com/golang/sys/blame/349b81fb5c64ec1734eb6ee148df25459ea48517/CONTRIBUTING.md#L26
https://github.com/golang/talks/blame/ea635b6f98864feb9a06de8d160af885e5999f09/CONTRIBUTING.md#L26
https://github.com/golang/text/blame/b7ef84aaf62aa3e70962625c80a571ae7c17cb40/CONTRIBUTING.md#L26
https://github.com/golang/debug/blame/545543929d8ccc043f8e537de66eafa69c90e046/CONTRIBUTING.md#L26
https://github.com/golang/build/blame/a6dd626c4c4f2d14d483b08abde160f89a436ecd/CONTRIBUTING.md#L26
https://github.com/golang/playground/blame/e9fb1cd9b74f68b2dd4b1c91d359bfce02df60de/CONTRIBUTING.md#L26
https://github.com/golang/tour/blame/057704a6290c29d3b08f62f96d3e2db6932f2ef5/CONTRIBUTING.md#L47
https://github.com/golang/proposal/blame/56005301f39f4a46203ec263cdfe7cf1c4959ac4/CONTRIBUTING.md#L26
https://github.com/golang/arch/blame/23d99967d08deb692f2acbfa3c61a51aef94971e/CONTRIBUTING.md#L26
https://github.com/golang/sublime-config/blame/ed5ebc0a1b1f6621db5c912472c63cb78b9c361e/CONTRIBUTING.md#L28
https://github.com/golang/sublime-build/blame/1cba804ede9c49725dafaf2b0650d274dc5cb086/CONTRIBUTING.md#L28
https://github.com/golang/sync/blame/fd80eb99c8f653c847d294a001bdf2a3a6f768f5/CONTRIBUTING.md#L26
https://github.com/golang/time/blame/6dc17368e09b0e8634d71cac8168d853e869a0c7/CONTRIBUTING.md#L26
https://github.com/golang/term/blame/aa45bf8df010468bfb784c40129051b79cfd6e43/CONTRIBUTING.md#L26
https://github.com/golang/perf/blame/ea1fc7ea91ba64ca9b3d0d016e9627a931b6abf8/CONTRIBUTING.md#L26
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100676 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100677 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100678 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100679 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100680 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100681 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100682 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100683 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100684 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100685 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100686 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100687 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100688 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100689 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100690 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100691 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100695 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100696 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100692 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100693 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100694 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100715 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100697 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100716 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2018

Change https://golang.org/cl/100717 mentions this issue: CONTRIBUTING.md: remove note about not accepting Pull Requests

gopherbot pushed a commit to golang/text that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: Iab70d5b21d561e139aed1fb569ab49634cfccd37
Reviewed-on: https://go-review.googlesource.com/100715
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/review that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I74b024457ece54c6b02c3b017cb003142b75b4f8
Reviewed-on: https://go-review.googlesource.com/100690
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/sync that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I892f30f02f9ae40554790e9c177cb79d193bffd5
Reviewed-on: https://go-review.googlesource.com/100696
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/sys that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: Ia2de9218885e0cfeaec79ed7417475230b063df0
Reviewed-on: https://go-review.googlesource.com/100692
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/talks that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: Ib544ebd3a7b3f2bd621e5054235a174358909042
Reviewed-on: https://go-review.googlesource.com/100693
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/term that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I582f013c13651c71d6fdf48be3b5e8ddf0341e80
Reviewed-on: https://go-review.googlesource.com/100694
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/time that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I54972e6370a1de467b36c58e69483d0b42350c88
Reviewed-on: https://go-review.googlesource.com/100697
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/blog that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I7f19310ff4dba014c3dff9b7d7791bfdcb4ebd44
Reviewed-on: https://go-review.googlesource.com/100677
Reviewed-by: Andrew Bonventre <andybons@golang.org>
gopherbot pushed a commit to golang/tools that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I6462c066b7efc4086496d9ed5e85a0d826f962bd
Reviewed-on: https://go-review.googlesource.com/100716
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/tour that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: Ic2d895e46e2aac8ccf4ac835a3c945cfaaec65b8
Reviewed-on: https://go-review.googlesource.com/100717
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: Ic0522fc0f682cd2fe60aa3081a47a025a76d7f9c
Reviewed-on: https://go-review.googlesource.com/100678
Reviewed-by: Andrew Bonventre <andybons@golang.org>
gopherbot pushed a commit to golang/arch that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I6bd8b9a38e9a22793a2791a2d46e7ea4087bff7a
Reviewed-on: https://go-review.googlesource.com/100676
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/playground that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I83709d8356c2d64d1e5bfe2fafe3a0436d57dc3c
Reviewed-on: https://go-review.googlesource.com/100688
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/perf that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I364b3583276d66057344e109e6ea413c6120191c
Reviewed-on: https://go-review.googlesource.com/100687
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/oauth2 that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I2cc878ba8ba163215a6430154bead5c79a5c5206
Reviewed-on: https://go-review.googlesource.com/100686
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: Ifbd5b9c8c8bb11635c49a390a8deda8bfed8e849
Reviewed-on: https://go-review.googlesource.com/100685
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/mobile that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I1ce066be52feff5d2372633776aa631e0ce7e713
Reviewed-on: https://go-review.googlesource.com/100684
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/image that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I9a3a920ec803ee612775aebfeaedb162d2266aa8
Reviewed-on: https://go-review.googlesource.com/100683
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/gddo that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I10753a1e9829a7b2f74c3e9bade62f8a1d4ef9e1
Reviewed-on: https://go-review.googlesource.com/100682
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/debug that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I7754e0bca3662aa9f930b796a59135e748b94707
Reviewed-on: https://go-review.googlesource.com/100680
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/exp that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I228e34ceb525d5d41d1146ef17d6f958a143026e
Reviewed-on: https://go-review.googlesource.com/100681
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/crypto that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: I99281b2bd1c1ca82c02269d232d7714852a3b94c
Reviewed-on: https://go-review.googlesource.com/100679
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit to golang/proposal that referenced this issue Mar 14, 2018
Updates golang/go#24185

Change-Id: Ic13f841b951220fdb271956184e13e8f8e16eba6
Reviewed-on: https://go-review.googlesource.com/100689
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@andybons
Copy link
Member

@andybons andybons commented Mar 14, 2018

The remaining notes about this have been removed. Thanks for collecting the instances, @jlburkhead!

@andybons andybons closed this Mar 14, 2018
OlingCat added a commit to Go-zh/tour that referenced this issue Mar 24, 2018
Updates golang/go#24185

Change-Id: Ic2d895e46e2aac8ccf4ac835a3c945cfaaec65b8
Reviewed-on: https://go-review.googlesource.com/100717
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bontibon
Copy link
Contributor

@bontibon bontibon commented May 28, 2018

@andybons The notice PR in the oauth2 package is still open: golang/oauth2#218

@andybons
Copy link
Member

@andybons andybons commented May 28, 2018

@bontibon closed. Thanks!

@golang golang locked and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.