Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: build doesn't work #24186

Closed
YoshikiShibata opened this issue Mar 1, 2018 · 1 comment

Comments

@YoshikiShibata
Copy link

commented Mar 1, 2018

Please answer these questions before submitting your issue. Thanks!

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

  1. At first, get oak
    go get github.com/YoshikiShibata/oak
  2. move to the directory where oak is installed.
  3. Try vgo build

vgo build fails and the contents of go.mod is modified to a wrong version:

YoshikinoMacBook-Pro:oak yoshiki$ pwd
/Users/yoshiki/gocode/src/github.com/YoshikiShibata/oak
YoshikinoMacBook-Pro:oak yoshiki$ cat go.mod
module "github.com/YoshikiShibata/oak"

require "github.com/YoshikiShibata/tools" v1.0
YoshikinoMacBook-Pro:oak yoshiki$ vgo build
vgo: finding github.com/YoshikiShibata/tools v1.0.0
vgo: github.com/YoshikiShibata/tools v1.0.0: unexpected status (https://api.github.com/repos/YoshikiShibata/tools/git/refs/tags/v1.0.0): 404 Not Found
vgo: finding github.com/YoshikiShibata/tools v1.0.0
vgo: github.com/YoshikiShibata/tools v1.0.0: unexpected status (https://api.github.com/repos/YoshikiShibata/tools/git/refs/tags/v1.0.0): 404 Not Found
vgo: unexpected status (https://api.github.com/repos/YoshikiShibata/tools/git/refs/tags/v1.0.0): 404 Not Found
YoshikinoMacBook-Pro:oak yoshiki$ cat go.mod
module "github.com/YoshikiShibata/oak"

require "github.com/YoshikiShibata/tools" v1.0.0
YoshikinoMacBook-Pro:oak yoshiki$ 
  1. try vgo get -u
YoshikinoMacBook-Pro:oak yoshiki$ vgo get -u
vgo: finding github.com/YoshikiShibata/tools latest
YoshikinoMacBook-Pro:oak yoshiki$ cat go.mod
module "github.com/YoshikiShibata/oak"

require "github.com/YoshikiShibata/tools" v1.0

Somehow, vgo build decides that the version of "github.com/YoshikiShibata/tools" is v1.0.0, but vgo get -u decides that the version is v1.0. Actually there is no tag of v1.0.0.

What did you expect to see?

vgo build doesn't fail.

What did you see instead?

vgo build fails.

Does this issue reproduce with the latest release (go1.10)?

System details

YoshikinoMacBook-Pro:oak yoshiki$ vgo version
go version devel +4338518da8 Thu Mar 1 00:16:20 2018 +0000 darwin/amd64 vgo:2018-02-20.1
go version devel +4338518da8 Thu Mar 1 00:16:20 2018 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/yoshiki/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/yoshiki/gocode"
GORACE=""
GOROOT="/Users/yoshiki/tools/go"
GOTMPDIR=""
GOTOOLDIR="/Users/yoshiki/tools/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rk/f21ym6ks1ydfj0rf1kqt1ctc0000gn/T/go-build391222562=/tmp/go-build -gno-record-gcc-switches -fno-common"
VGOMODROOT=""
GOROOT/bin/go version: go version devel +4338518da8 Thu Mar 1 00:16:20 2018 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +4338518da8 Thu Mar 1 00:16:20 2018 +0000
uname -v: Darwin Kernel Version 17.4.0: Sun Dec 17 09:19:54 PST 2017; root:xnu-4570.41.2~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.3
BuildVersion:	17D102
lldb --version: lldb-900.0.64
  Swift-4.0

@gopherbot gopherbot added this to the vgo milestone Mar 1, 2018

@kardianos

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2018

Two problems:

  1. vgo sees v1.0 and takes it. This is issue #23954
  2. The tag is formatted incorrectly, it should be "v1.0.0".

Probably a duplicate.

@kardianos kardianos closed this Mar 2, 2018

@golang golang locked and limited conversation to collaborators Mar 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.