net/http: connReader.handleReadError doesn't use its error parameter

[mvdan]

This is the case since the func was added in October 2016, as it hasn't been touched since:

func (cr *connReader) handleReadError(err error) {
       cr.conn.cancelCtx()
       cr.closeNotify()
}

Should the func not receive the parameter, or make use of it?

I found this with a static analysis tool - I don't necessarily think this is a bug. I simply agree with the tool that the code is a bit suspicious.

/cc @bradfitz

[spf13]

ping @bradfitz for decision

[gopherbot]

Change https://golang.org/cl/122675 mentions this issue: net/http: comment handleReadError more, superficially use its argument

[bradfitz]

@mvdan, @andybons and I were curious which static analysis tool found this, and whether it handles _ error okay now.

[mvdan]

@bradfitz @andybons it's https://github.com/mvdan/unparam, which should be ok-ish at avoiding false positives. In particular, it does ignore unnamed and underscore parameters. But as always, if you find a bug, please report it :)