cmd/compile: revisit append codegen #24209
Open
Labels
Milestone
Comments
I was wrong. Therefore, this is not a release blocker. Punting to Go 1.12. |
Punting to 1.13, too late for anything major in 1.12. |
This comment has been hidden.
This comment has been hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CLs 21813 and 22197 optimized the code generated for append. It was done in part to address #14921, but while I was there, I also focused on things like avoiding spills in the fast path.
Several things have changed in the compiler since then:
All this suggests to me that we may be able to simplify and improve the code generated for append.
I also suspect that the "no write barriers for in-place appends" optimization may have gotten lost during the write barrier move. More details about that in a comment-to-come over in #14921.
That's a significant optimization. Tentatively marking this as a release blocker for that reason.
cc @randall77 @cherrymui @aclements @mvdan
The text was updated successfully, but these errors were encountered: