Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: revisit append codegen #24209
CLs 21813 and 22197 optimized the code generated for append. It was done in part to address #14921, but while I was there, I also focused on things like avoiding spills in the fast path.
Several things have changed in the compiler since then:
All this suggests to me that we may be able to simplify and improve the code generated for append.
I also suspect that the "no write barriers for in-place appends" optimization may have gotten lost during the write barrier move. More details about that in a comment-to-come over in #14921.
That's a significant optimization. Tentatively marking this as a release blocker for that reason.