Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/guru: change package referrers to show imports rather than qualified identifiers #24275

Open
josharian opened this issue Mar 6, 2018 · 1 comment
Assignees
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Mar 6, 2018

cmd/guru's packageReferrers contains this TODO:

			// TODO(adonovan): perhaps more useful would be to show imports
			// of the package instead of qualified identifiers.

This seems more useful, because there'd be fewer results, which means the user is less likely to drown in them. It also admits of a dramatically cheaper implementation, because it could be done entirely via go/parser, with parser.ImportsOnly.

@alandonovan how do you feel about pulling the trigger on this?

cc @keegancsmith -- see https://github.com/sourcegraph/go-langserver/blob/feba79e88e9cca61e450f5c15d2c01d597e2d46c/langserver/references.go#L59

@spf13

This comment has been minimized.

Copy link
Contributor

@spf13 spf13 commented Mar 26, 2018

ping @alandonovan for decision

@gopherbot gopherbot added the Tools label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.