Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: heapdump16 and heapdump17 are missing #24295

Closed
jeffallen opened this issue Mar 7, 2018 · 4 comments
Closed

runtime: heapdump16 and heapdump17 are missing #24295

jeffallen opened this issue Mar 7, 2018 · 4 comments

Comments

@jeffallen
Copy link
Contributor

@jeffallen jeffallen commented Mar 7, 2018

What version of Go are you using (go version)?

1.10

What did you do?

Trying to decode heap dumps. The godoc leads me to https://github.com/golang/go/wiki/heapdump15
, but heap dump version 1.6 and 1.7 exist as well:

  1. 1.7: 30f93f0
  2. 1.6: cedbbfa (but the code review in https://go-review.googlesource.com/c/go/+/18912 seems to indicate there was no actual change?)

It would be helpful to have the specification for heapdump16 and heapdump17 in the wiki.

@ALTree ALTree changed the title heapdump16 and heapdump17 are missing runtime: heapdump16 and heapdump17 are missing Mar 7, 2018
@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Mar 7, 2018

@randall77

This comment has been minimized.

Copy link
Contributor

@randall77 randall77 commented Mar 7, 2018

1.5->1.6 had no changes other than the header.
1.6->1.7 has one very minor change to how to tell whether an interface is direct.

I'll update the wiki.

@randall77

This comment has been minimized.

Copy link
Contributor

@randall77 randall77 commented Mar 7, 2018

Done.
Let me know if my changes are clear.

@randall77 randall77 closed this Mar 7, 2018
@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Mar 7, 2018

@golang golang locked and limited conversation to collaborators Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.