Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: too many comments on a new pull request #24323

Open
mvdan opened this issue Mar 9, 2018 · 2 comments
Open

x/build/cmd/gerritbot: too many comments on a new pull request #24323

mvdan opened this issue Mar 9, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mvdan
Copy link
Member

mvdan commented Mar 9, 2018

For example: #24322

I would expect two comments - "This PR has been imported to Gerrit", and the forward of the "Congratulations on opening your first change" automated comment.

However, somehow gerritbot (or perhaps GitHub?) seem to think that the pull request needed importing twice, or that it was updated when it doesn't look like it was.

Or perhaps the pull request was updated while gerritbot was importing it, resulting in these duplicate and confusing messages.

@gopherbot gopherbot added this to the Unreleased milestone Mar 9, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 9, 2018
@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 29, 2018
@andybons
Copy link
Member

You say "for example" but has this happened on other PRs as well?

@andybons andybons self-assigned this Mar 29, 2018
@mvdan
Copy link
Member Author

mvdan commented Apr 1, 2018

Not that I have noticed, but I haven't gone through all of them. I have only seen it once, so it's likely not something that happens often

@andybons andybons removed their assignment Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants