Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: too many comments on a new pull request #24323

Open
mvdan opened this issue Mar 9, 2018 · 2 comments

Comments

Assignees

@andybons andybons

Labels
Builders NeedsInvestigation
Projects
None yet
Milestone
  Unreleased
3 participants
@mvdan @andybons @gopherbot
@mvdan
Copy link
Member

commented Mar 9, 2018

For example: #24322

I would expect two comments - "This PR has been imported to Gerrit", and the forward of the "Congratulations on opening your first change" automated comment.

However, somehow gerritbot (or perhaps GitHub?) seem to think that the pull request needed importing twice, or that it was updated when it doesn't look like it was.

Or perhaps the pull request was updated while gerritbot was importing it, resulting in these duplicate and confusing messages.

@gopherbot gopherbot added this to the Unreleased milestone Mar 9, 2018

@gopherbot gopherbot added the Builders label Mar 9, 2018

@andybons andybons added the NeedsInvestigation label Mar 29, 2018

@andybons

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 29, 2018

You say "for example" but has this happened on other PRs as well?

@andybons andybons self-assigned this Mar 29, 2018

@mvdan

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 1, 2018

Not that I have noticed, but I haven't gone through all of them. I have only seen it once, so it's likely not something that happens often
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.