Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/vgo: vgo does not fix the timestamp in a pseudo-version #24369
What version of Go are you using (
Using that row of zeros makes it a lot easier to specify the date in advance.
I'm not even sure in which timezone I had to specify the string after I had extracted it from a given commit info.
So in my opinion the actual check should only be introduced after we have an easy and documented way to extract the pseudoversion from a given package/module without having to do the
Run "go build" and then "cat go.mod". What does it say? It should be updated to have the right timestamp.
For that matter, even if you'd written:
it's supposed to get updated to turn into the right pseudo-version. Can you let me know if that's what you're seeing?
In my case it was
Then I searched for ways to force another git-ref.
So I tried
But this behaviour is not documented (or at least not easily discoverable), therefore my confusion.
Of course I am aware of the fact, that
But as we are talking about it, is it possible to use arbitrary refs (branch, tag, commit) in a human readable way?
How does this play with other VCS like SVN?
Here are the results of running
Before running the commands, here are
Then, I run
Notably, if I instead write my
then after running
CL 106799 changed the mod file parser to be call the fixer function for every module, version pair, not just the ones with non-canonical semantic versions. Of course, we don't want to hit the network for every line of every go.mod, when most of them are fine. Skip the network for the ones that are syntactically OK, including proper matching between the module path and major version. For golang/go#24369. Change-Id: Id101d8f3c10bccde8a755ae734dbacf4d0a36f8d Reviewed-on: https://go-review.googlesource.com/107655 Run-TryBot: Russ Cox <firstname.lastname@example.org> Reviewed-by: Bryan C. Mills <email@example.com>