Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
database/sql: segfault in connection pool when the driver frequently fails to connect #24445
What version of Go are you using (
I'm having trouble reproducing, but here is what I have confirmed:
I can confirm so far when I insert a call to
Thanks for the fix. I've been running my program with the
The panic happened two times on different computers, and it took 3~4 days of continuously failing connection attempts.
…before use The connRequest may return a nil conn value. However in a rare case that is difficult to test for it was being passed to DB.putConn without a nil check. This was an error as this made no sense if the driverConn is nil. This also caused a panic in putConn. A test for this would be nice, but didn't find a sane way to test for this condition. Updates #24445 Fixes #25235 Change-Id: I827316e856788a5a3ced913f129bb5869b7bcf68 Reviewed-on: https://go-review.googlesource.com/102477 Run-TryBot: Daniel Theophanes <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Alexey Palazhchenko <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> (cherry picked from commit b98ffdf) Reviewed-on: https://go-review.googlesource.com/c/146778 Run-TryBot: Brad Fitzpatrick <email@example.com> Reviewed-by: Katie Hockman <firstname.lastname@example.org>