Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: https://golang.org/cl/99780 breaks the ARM FreeBSD builder #24507

Closed
paulzhol opened this issue Mar 23, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@paulzhol
Copy link
Member

commented Mar 23, 2018

https://build.golang.org/log/c259fe9a61718ded041c678b6c115abbe0f57a69

Building Go toolchain2 using go_bootstrap and Go toolchain1.
runtime: this CPU has no floating point hardware, so it cannot run
this GOARM=7 binary. Recompile using GOARM=5.
go tool dist: FAILED: /tmp/workdir-host-freebsd-arm-paulzhol/go/pkg/tool/freebsd_arm/go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: exit status 1

The AT_HWCAP elf auxv was only introduced in
https://svnweb.freebsd.org/base?view=revision&revision=323579
https://svnweb.freebsd.org/base?view=revision&revision=323580
and MFC'ed to stable/11 in
https://svnweb.freebsd.org/base?view=revision&revision=324687
https://svnweb.freebsd.org/base?view=revision&revision=325810

It is not available on freebsd-arm-paulzhol, which is compiled from FreeBSD 11.1-RELEASE.

Also the AT_HWCAP value should have been 26 instead of 16.
16 is actually the value of AT_CANARY, essentially a pseudo random stream of 32/64 bytes.

@paulzhol paulzhol self-assigned this Mar 23, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Mar 23, 2018

Change https://golang.org/cl/102355 mentions this issue: runtime: partially revert "runtime: parse auxv on freebsd"

@gopherbot gopherbot closed this in 6f47fa2 Mar 23, 2018

@gopherbot

This comment has been minimized.

Copy link

commented May 26, 2018

Change https://golang.org/cl/114822 mentions this issue: runtime: use the correct AT_HWCAP auxv constant on freebsd

gopherbot pushed a commit that referenced this issue May 26, 2018

runtime: use the correct AT_HWCAP auxv constant on freebsd
In golang.org/cl/102355 I mistakenly used 26 instead of 25 as the AT_HWCAP value.
26 is AT_HWCAP2. While experimenting with FreeBSD-11.2-BETA3 (where both values are
being supplied in the auxv), the AT_HWCAP2 value read is 0 which triggers the error again:

  runtime: this CPU has no floating point hardware, so it cannot run this GOARM=7 binary. Recompile using GOARM=5.

Updates #24507.

Change-Id: Ide04b7365d8f10e4650edf4e188dd58bdf42cc26
Reviewed-on: https://go-review.googlesource.com/114822
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.