Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: store CL number in the query parameters #24626

Open
kevinburke opened this issue Apr 1, 2018 · 1 comment
Open

x/build/cmd/coordinator: store CL number in the query parameters #24626

kevinburke opened this issue Apr 1, 2018 · 1 comment
Labels
Milestone

Comments

@kevinburke
Copy link
Contributor

@kevinburke kevinburke commented Apr 1, 2018

If the build completes, you get this message:

TryBot result not found (already done, invalid, or not yet discovered from Gerrit). Check Gerrit for results.

If we stored the CL number in the URL (for example commit=deadbeef&cl=123456), and we couldn't find the commit number, we could assume the build is complete and either redirect you back to it, or provide a link to the right CL from the complete farmer build.

@gopherbot gopherbot added this to the Unreleased milestone Apr 1, 2018
@toothrot
Copy link
Contributor

@toothrot toothrot commented Sep 4, 2019

That page could definitely be more informative. This sounds related to #10313 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants