Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
runtime: gentraceback no longer skips stack frames when printing #24628
I got some time today to finish up and add a rigorous test for CL https://go-review.googlesource.com/#/c/go/+/37222 which involves printing the top and bottom n frames for easy reading in case of a massive stackoverflow.
To detect that we are printing stackframes, we have this condition
and in order for it to work, we need to be able to skip a bunch of frames when printing the bottom n stack frames.
However, with code that we used to skip through physical frames previously, CL https://go-review.googlesource.com/37854 aka commit ee97216 changed that behavior assuming that we'd never use
The code that disabled proper skipping is ee97216#diff-5a2de8a1053d4e11fbc71407a5361e93L321