Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: Update MSI to check for Win7 SP1 on Windows [Go 1.11] #24643

Closed
fkollmann opened this issue Apr 2, 2018 · 1 comment
Closed

x/build/cmd/release: Update MSI to check for Win7 SP1 on Windows [Go 1.11] #24643

fkollmann opened this issue Apr 2, 2018 · 1 comment
Labels
Builders FrozenDueToAge NeedsFix release-blocker
Milestone
Go1.11

Comments

@fkollmann
Copy link

@fkollmann fkollmann commented Apr 2, 2018

Caused by #23380 (drop of WinXP support)

For official version table, see here: https://msdn.microsoft.com/library/aa370556.aspx

Note: Regarding the version table, build number should no longer be checked.
@fkollmann fkollmann mentioned this issue Apr 2, 2018
Closed
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 2, 2018

Change https://golang.org/cl/103856 mentions this issue: cmd/release: MSI installer is now checking against Win7 SP1
@fkollmann fkollmann changed the title Update release tool to check for Win7 SP1 on Windows Update MSI to check for Win7 SP1 on Windows [Go 1.11] Apr 2, 2018
@bradfitz bradfitz changed the title Update MSI to check for Win7 SP1 on Windows [Go 1.11] x/build: Update MSI to check for Win7 SP1 on Windows [Go 1.11] Apr 2, 2018
@gopherbot gopherbot added this to the Unreleased milestone Apr 2, 2018
@gopherbot gopherbot added the Builders label Apr 2, 2018
@bradfitz bradfitz added NeedsFix and removed Builders labels Apr 2, 2018
@gopherbot gopherbot added the Builders label Apr 2, 2018
@bradfitz bradfitz modified the milestones: Unreleased, Go1.11 Apr 2, 2018
@gopherbot gopherbot added the Builders label Apr 2, 2018
@bradfitz bradfitz changed the title x/build: Update MSI to check for Win7 SP1 on Windows [Go 1.11] x/build/cmd/release: Update MSI to check for Win7 SP1 on Windows [Go 1.11] Apr 2, 2018
@golang golang locked and limited conversation to collaborators Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders FrozenDueToAge NeedsFix release-blocker
Projects
None yet
Milestone
Go1.11
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bradfitz @fkollmann @gopherbot
You can’t perform that action at this time.