Skip to content

strings: TestBuilderGrow test flake #24647

Description

@josharian

https://build.golang.org/log/bc6b2519adffb638dbe8ad1fcd447d1737740e6d

--- FAIL: TestBuilderGrow (0.04s)
	builder_test.go:94: growLen=10000: allocation occurred during write
FAIL
FAIL	strings	5.487s

@aclements commented over in #24631 about alloc measurements in the testing package:

I worry slightly that the random background allocations that aren't coupled to iterations (e.g., when a GC cycle runs) would almost always cause this number to be slightly above a whole number and that that could confuse people.

Perhaps that effect is responsible for this build failure. Note that the strings package has its own handrolled alloc count implementation, one which does no averaging and is thus more susceptible to such flakes.

cc @cespare @bradfitz

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.help wanted

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions