Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
proposal: syscall: implement Flock on Solaris in terms of FcntlFlock #24684
go version go1.10.1 solaris/amd64
okay I read that
That being said, programs are still going to be using syscall.Flock for years to come
But it DOES have FcntlFlock.
So would it be permissible for me to submit a patch to syscall_solaris.go, that gives Solaris an implementation of Flock on top of FcntlFlock ?
These are two semantically different locking APIs. I don't see why we'd implement one in terms of the other. Syscall is about raw access to the underlying system, not simulations.
In any event, x/sys/unix is the place to add both, and it looks like it already has both.
syscall is frozen, as others have said. We'd only add to syscall if uses within the standard library were affected, and I don't see any.