Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: Feature request rules file for -u and -p updates #24690

Closed
mattfarina opened this issue Apr 5, 2018 · 1 comment

Comments

@mattfarina
Copy link

commented Apr 5, 2018

With vgo get -u and vgo get -p you'll be able to update dependencies which includes a focus on the patch file level. Instead of doing everything or individual dependencies at the console it would be useful to have a file that holds the rules per dependency. For example, there are 3 dependencies A, B, and C. For A and C the equivalent of -u is used while on dependency B -p is used. vgo along with a config file will update following the rules.

@gopherbot gopherbot added this to the vgo milestone Apr 5, 2018

@rsc

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2018

You're asking for a configuration file to change the meaning of vgo get -u and vgo get -p on a per-module basis. I don't see this happening. The go command eschews this kind of customization complexity. If you want to make it easier to update certain dependencies a certain way, I would suggest instead a shell script. In your example:

vgo get -u A C
vgo get -p B

(If you name it update.bat and mark it executable it will work equally well on Unix and Windows. :-) )

Note that the get commands don't work the right way today to accept those arguments, but the plan is to make them work. Perhaps the lack of being able to write those commands today is what motivated the suggestion of a separate config file.

@rsc rsc closed this Apr 5, 2018

@golang golang locked and limited conversation to collaborators Apr 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.