Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: TestPassFD fails on netbsd/arm #24771

Closed
tklauser opened this Issue Apr 9, 2018 · 4 comments

Comments

Projects
None yet
6 participants
@tklauser
Copy link
Member

tklauser commented Apr 9, 2018

--- FAIL: TestPassFD (0.13s)
	syscall_unix_test.go:210: child process ReadAll: "", invalid argument; want "Hello from child process!\n"

See the recent build logs:

https://build.golang.org/log/256ba2fefaa05e5bcf91e36e824a4aa7edda4e45
https://build.golang.org/log/6a716f8518326a60f291a7efad8884d27f6c4470
https://build.golang.org/log/fff5ee432875da78bd360ef7033fd85f26999a84

/cc @bsiegert @bradfitz

@tklauser tklauser added the OS-NetBSD label Apr 10, 2018

@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone Apr 18, 2018

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 29, 2018

@katiehockman

This comment has been minimized.

Copy link
Contributor

katiehockman commented Feb 11, 2019

Note for future triaging, this is still failing for the same reason. More recent failure: https://build.golang.org/log/efdaf6aacac31822e9c3312a5e635a7102bc822b

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 28, 2019

Change https://golang.org/cl/164458 mentions this issue: syscall: use 64-bit alignment on netbsd-arm

gopherbot pushed a commit that referenced this issue Feb 28, 2019

syscall: use 64-bit alignment on netbsd-arm
netbsd-arm needs the same override to the alignment function as
openbsd-arm. This fixes the TestPassFD failure.

Update #24771

Change-Id: Ib124fc776f6e2e3b3932784365c2bd3944523a52
Reviewed-on: https://go-review.googlesource.com/c/164458
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 28, 2019

Change https://golang.org/cl/164497 mentions this issue: x/sys/unix: use 64-bit alignment on netbsd-arm

gopherbot pushed a commit to golang/sys that referenced this issue Feb 28, 2019

unix: use 64-bit alignment on netbsd-arm
This is the same change as CL 164458.
netbsd-arm needs the same override to the alignment function as
openbsd-arm. This fixes the TestPassFD failure.

Update golang/go#24771

Change-Id: I9c6451feb11ec9810de9273b1324b0c23d7e6d11
Reviewed-on: https://go-review.googlesource.com/c/164497
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 28, 2019

Change https://golang.org/cl/164460 mentions this issue: cmd: update vendored golang.org/x/sys/unix

@gopherbot gopherbot closed this in 336ae0d Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.