Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcmd/link: provide better error message than "relocation target main.main not defined" when no func main provided #24809
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
That's #10978 |
This comment has been minimized.
This comment has been minimized.
|
Thanks. I think those are close enough that I'll close this as a dup. |
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/113955 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jun 5, 2018
For given program with 2 undefined relocations (main and undefined):
package main
func undefined()
func defined() int {
undefined()
undefined()
return 0
}
var x = defined()
"go tool link" produces these errors:
main.defined: relocation target main.undefined not defined
main.defined: relocation target main.undefined not defined
runtime.main_main·f: relocation target main.main not defined
main.defined: undefined: "main.undefined"
main.defined: undefined: "main.undefined"
runtime.main_main·f: undefined: "main.main"
After this CL is applied:
main.defined: relocation target main.undefined not defined
runtime.main_main·f: function main is undeclared in the main package
Fixes #10978
Improved error message for main proposed in #24809.
Change-Id: I4ba8547b1e143bbebeb4d6e29ea05d932124f037
Reviewed-on: https://go-review.googlesource.com/113955
Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There has been a recent spate of issues and noise on issues, in which people report that the linker is complaining:
relocation target main.main not defined. This happens when the main package has nofunc main.Since that is a common error mode, particularly for new Go programmers, we should provide a more useful error message.
I thought there was an existing issue open for this, but I can't find it.