New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add playground to build.golang.org #24823
Comments
You should also add it to build.golang.org |
@andybons, is there any good doc describing how trybots work besides https://go.googlesource.com/build/ ? |
Good question. @bradfitz ? |
Nope, not besides reading the coordinator code. But this is not a good starter project. |
Something is not clear. We have to test Playground via it's docker container. But where should we run that? I think it does not make much sense to run it on many platforms. Also I fail to find repos tests in similar fashion, but running not a |
Yes, we have no way to do this right now. That's why it's not a good starter project. This will be a lot of work and require a number of changes across our build system. |
Rough outline, though:
|
We just open sourced a tool today to make docker build on kubernetes less of a mess: github.com/GoogleCloudPlatform/kaniko |
Resolving this issue should be easier now compared to 2018 for at least one reason: thanks to the module mirror, additional non-golang.org/x dependencies will no longer be a problem for the builders/trybots to fetch. I'm not if something Docker-related also needs to be done, but @toothrot may have more context. |
The integration tests changed in #25224 to require two docker containers running in a docker network, and also require the ability to run |
I discovered that the playground's TryBot's have been broken for some time (https://go.dev/issue/59218). I think we should revisit this issue, and also consider adding RelUI automation to update the playground's dependencies. |
Currently running trybots for
x/playground
produces this:https://storage.googleapis.com/go-build-log/2d26a65f/linux-amd64_e35969e6.log
Add Playground to build.golang.org.
Make builders be able to test Playground in the its docker container.
The text was updated successfully, but these errors were encountered: