net/http: test spams stderr #24831
net/http: test spams stderr #24831
Comments
Thank you for this report @bradfitz For further investigation, I'll kindly page:
|
Sorry. The first one's my fault. I'll look into it. The second looks unlikely to be caused by what I did to cause the first. |
@mikesamuel no worries :) In deed, the second one was caused by a different commit
|
Change https://golang.org/cl/106756 mentions this issue: |
This changes rawResponse to install a logger before Serve()ing and makes the log output available to tests. Updates #24831 Updates CL 89275 Change-Id: I0fb636a35b05959ca9978d5d8552f38b7cf8e8b5 Reviewed-on: https://go-review.googlesource.com/106756 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sorry for the late reply @mikedanese, I've been travelling and was away from my computer for a bit. I went through the history https://github.com/golang/go/commits/master/src/crypto and commits before and after yours after some bisection using some hacked up bash script to do binary searches, recompile the Go tree and then find regressions(but it isn't yet complete so not yet releasing it ;)) @mikedanese you can try to confirm it yourself, the commit before yours 8a15192 didn't produce that result but yours c529141 did and so did the commit after yours 0b37f05 |
@mikedanese thank you for the thorough investigation, I was just following changes in In that case /cc @pquerna and @FiloSottile. |
Change https://golang.org/cl/107817 mentions this issue: |
Running
go test
on a package should be quiet and not spam to stderr.But:
The first log line was added in 1a677e0 (/cc mikesamuel).
I haven't looked into the second.
Help fixing these would be great. Thanks!
The text was updated successfully, but these errors were encountered: