Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: auto-wrap description #24832

Open
myitcv opened this issue Apr 12, 2018 · 3 comments
Open

x/build/cmd/gerritbot: auto-wrap description #24832

myitcv opened this issue Apr 12, 2018 · 3 comments

Comments

@myitcv
Copy link
Member

@myitcv myitcv commented Apr 12, 2018

Per https://go-review.googlesource.com/c/vgo/+/105335/9//COMMIT_MSG#9 it would be good/nice to have gerritbot auto-wrap the first comment to save people having to do this by hand (which in a webpage text box is painful)

cc @andybons

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 13, 2018

I'm not entirely comfortable with breaking long lines in the CL description. Those lines might be source code or other text with meaningful line breaks. I don't care much what happens with text that people type into the edit box on the web page, but I don't see how to reliably do the right thing with description sent in via git mail.

@myitcv

This comment has been minimized.

Copy link
Member Author

@myitcv myitcv commented Apr 13, 2018

@ianlancetaylor - might be I've misclassified this for "gerritbot"; I was only looking to automate the wrapping of the description take from the Github PR when populating the CL description.

i.e. for golang/vgo#3 we would auto-wrap the description that is in the first comment:

screen shot 2018-04-13 at 23 51 28

Or did I misunderstand your point?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 13, 2018

Ah, no, I misunderstood. Sure, it's fine with me to wrap when moving from a GitHub pull request to Gerrit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.