Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/gerritbot: impersonate reviewer accounts #24837

Open
FiloSottile opened this issue Apr 13, 2018 · 3 comments

Comments

@FiloSottile
Copy link
Member

commented Apr 13, 2018

The experience of only receiving messages from @gopherbot can be a bit impersonal and confusing. When migrating from Google Code we had gopherbot impersonate accounts. We could do the same for comments on PRs.

It would be opt-in but as long as the main reviewers are covered, I think it would achieve its goal.

/cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Apr 13, 2018

@gopherbot gopherbot added the Builders label Apr 13, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

We'd need to re-collect OAuth2 tokens from everybody. And resurrect the tool we'd built to collect them from users. And that means we need to be in the business of holding them. Previously we collected them once, proved to GitHub that we had them, and then GitHub mass-impersonated everybody for us (for those accounts we'd collected permission for), and then we deleted the tokens.

Doing this going forward means we're going from storing zero user data to non-zero user data (even if the number of users is less than 50 or 100), and that means a bit more paperwork sometimes.

We'd also need to maintain our Gerrit email <-> GitHub mapping table more.

So, we can do this. But it's work.

@andybons

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

Removing NeedsDecision because that gets brought up at proposal meetings. We have the right people looking at this.

@mvdan

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

Perhaps related to #24382, in how the bots should be special Gerrit users.

@andybons andybons removed their assignment Sep 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.