Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
path/filepath: TestEvalSymlinks tests with "/" prefix fail in Windows #24846
What version of Go are you using (
@JoshVarga I cannot reproduce this. How do I reproduce this?
You say you are using go1.10.1. But you error message
does not match the code https://github.com/golang/go/blob/go1.10.1/src/path/filepath/path_test.go#L798 Why?
Please provide more details about your environment so I can try and reproduce it here:
I don't think there is a bug in Go just in the test. I believe it is because filepath.Clean reduces the root for a Windows path to C:\ for example but it will not add a volume name onto a path like "/" (that was used in the test).
1.10.1 is my bootstrap compiler to build tip source. I boiled down the code from path_test.go so that it reproduces the issue compiling in 1.10.1 as simple as possible.
This is my full go env
When run the above code on my Windows 10 Pro machine I get:
As requested here is my %TMP%
@JoshVarga thank you for providing your environment details. I can reproduce your problem now. The important difference between your setup and mine is that your GOROOT directory lives on the different drive from your TMP directory.
I think we need to adjust the test to accommodate for that scenario. I have not decided what to do yet. I will think about this when I have free time.