Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: enable more builders for x/sys #24893

Closed
tklauser opened this issue Apr 17, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@tklauser
Copy link
Member

commented Apr 17, 2018

At the moment all golang.org/x/* sub-repositories are built/tested on a limited set of builders. For golang.org/x/sys it would be nice to enable builders for dragonfly/amd64 and solaris/amd64 at least (and maybe freebsd/arm and netbsd/arm) to increase test coverage. For now I run semi-regular build/tests of x/sys on these via gomote or on my local VMs/machines, but it would be nice to have it automated.

/cc @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Apr 17, 2018

@gopherbot gopherbot added the Builders label Apr 17, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

You mean trybots (pre-submit) or build.golang.org columns (post-submit) builders?

@krytarowski

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2018

Were the patches for NetBSD/arm upstreamed? We used to have a long list of them.. perhaps mostly for the 1.4 version.

@tklauser

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2018

@bradfitz Primarily, I mean post-submit builder. But pre-submit would of course also be nice, if it's possible to have them only for x/sys. I guess it doesn't make sense for most of the other x/* repos.

@paulzhol

This comment has been minimized.

Copy link
Member

commented Apr 18, 2018

freebsd/arm is building x/sys and x/net
https://build.golang.org/?repo=golang.org%2fx%2fsys#
https://build.golang.org/?repo=golang.org%2fx%2fnet#.
It is just horribly behind the regular commits that it can't keep up. I'll try to replace it with a faster hardware soon (depending whether the new board works with FreeBSD11-STABLE).
If that fails, I would try to setup a cross-builder similar to the iOS one.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

New set for now for go vs net vs sys:

=== RUN   TestListTrybots/sys
--- PASS: TestListTrybots (0.00s)
    --- PASS: TestListTrybots/go (0.00s)
        builders_test.go:28: Builders:
        builders_test.go:30:   - freebsd-amd64-12_0
        builders_test.go:30:   - js-wasm
        builders_test.go:30:   - linux-386
        builders_test.go:30:   - linux-amd64
        builders_test.go:30:   - linux-amd64-race
        builders_test.go:30:   - misc-compile
        builders_test.go:30:   - misc-compile-freebsd
        builders_test.go:30:   - misc-compile-mips
        builders_test.go:30:   - misc-compile-nacl
        builders_test.go:30:   - misc-compile-netbsd
        builders_test.go:30:   - misc-compile-openbsd
        builders_test.go:30:   - misc-compile-plan9
        builders_test.go:30:   - misc-compile-ppc
        builders_test.go:30:   - misc-vet-vetall
        builders_test.go:30:   - nacl-386
        builders_test.go:30:   - nacl-amd64p32
        builders_test.go:30:   - openbsd-amd64-62
        builders_test.go:30:   - windows-386-2008
        builders_test.go:30:   - windows-amd64-2016
    --- PASS: TestListTrybots/net (0.00s)
        builders_test.go:28: Builders:
        builders_test.go:30:   - freebsd-amd64-12_0
        builders_test.go:30:   - linux-386
        builders_test.go:30:   - linux-amd64
        builders_test.go:30:   - linux-amd64-race
        builders_test.go:30:   - misc-compile
        builders_test.go:30:   - misc-compile-freebsd
        builders_test.go:30:   - misc-compile-mips
        builders_test.go:30:   - misc-compile-nacl
        builders_test.go:30:   - misc-compile-netbsd
        builders_test.go:30:   - misc-compile-openbsd
        builders_test.go:30:   - misc-compile-plan9
        builders_test.go:30:   - misc-compile-ppc
        builders_test.go:30:   - misc-vet-vetall
        builders_test.go:30:   - nacl-386
        builders_test.go:30:   - nacl-amd64p32
        builders_test.go:30:   - openbsd-amd64-62
        builders_test.go:30:   - windows-386-2008
        builders_test.go:30:   - windows-amd64-2016
    --- PASS: TestListTrybots/sys (0.00s)
        builders_test.go:28: Builders:
        builders_test.go:30:   - freebsd-386-10_4
        builders_test.go:30:   - freebsd-amd64-10_4
        builders_test.go:30:   - freebsd-amd64-11_2
        builders_test.go:30:   - freebsd-amd64-12_0
        builders_test.go:30:   - linux-386
        builders_test.go:30:   - linux-amd64
        builders_test.go:30:   - linux-amd64-race
        builders_test.go:30:   - misc-compile
        builders_test.go:30:   - misc-compile-freebsd
        builders_test.go:30:   - misc-compile-mips
        builders_test.go:30:   - misc-compile-nacl
        builders_test.go:30:   - misc-compile-netbsd
        builders_test.go:30:   - misc-compile-openbsd
        builders_test.go:30:   - misc-compile-plan9
        builders_test.go:30:   - misc-compile-ppc
        builders_test.go:30:   - misc-vet-vetall
        builders_test.go:30:   - nacl-386
        builders_test.go:30:   - nacl-amd64p32
        builders_test.go:30:   - netbsd-amd64-8_0
        builders_test.go:30:   - openbsd-386-64
        builders_test.go:30:   - openbsd-amd64-62
        builders_test.go:30:   - windows-386-2008
        builders_test.go:30:   - windows-amd64-2016

Note that I've enabled more GCE builder types for the "sys" repo at least: more FreeBSD types, NetBSD, more OpenBSD.

@gopherbot

This comment has been minimized.

Copy link

commented Oct 26, 2018

Change https://golang.org/cl/145157 mentions this issue: dashboard, cmd/coordinator: move more config out of coordinator into dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.