Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: sigprof handler crashes backtracing runtime.nanotime [1.10 backport] #24931

Closed
heschik opened this issue Apr 18, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@heschik
Copy link
Contributor

commented Apr 18, 2018

Original issue: #24925. It should be backported because it risks causing an unavoidable crash when CPU profiling is running.

@heschik heschik added this to the Go1.10.2 milestone Apr 18, 2018

@andybons

This comment has been minimized.

Copy link
Member

commented Apr 18, 2018

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2018

OK for backport.

@gopherbot

This comment has been minimized.

Copy link

commented Apr 18, 2018

Change https://golang.org/cl/107875 mentions this issue: [release-branch.go1.10] runtime: use saved state in SIGPROF handler for vDSO calls

@gopherbot

This comment has been minimized.

Copy link

commented Apr 18, 2018

Change https://golang.org/cl/107955 mentions this issue: [release-branch.go1.10] runtime: get traceback from VDSO code

@heschik

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

We changed our minds, so I'll abandon the CLs. There's no CherryPickRejected label; should I just close the issue?

@andybons

This comment has been minimized.

Copy link
Member

commented Apr 27, 2018

Yep just close it.

@andybons andybons closed this Apr 27, 2018

@andybons andybons removed this from the Go1.10.2 milestone Apr 27, 2018

@golang golang locked and limited conversation to collaborators Apr 27, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.