Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccgo: objcopy needs to be required by configure #24966

Open
ppbrown opened this issue Apr 20, 2018 · 0 comments
Open

gccgo: objcopy needs to be required by configure #24966

ppbrown opened this issue Apr 20, 2018 · 0 comments
Labels
Milestone

Comments

@ppbrown
Copy link

@ppbrown ppbrown commented Apr 20, 2018

gcc 7.3.0

"objdump" is actually a required executable for building gccgo, as I understand it.
Therefore, it would be nice to flag it as such, in libgo/configure, rather than have the build bomb out later, mysteriously.

Oddly, there is already a line related to it, in configure.ac:

AC_CHECK_TOOL(OBJCOPY, objcopy, missing-objcopy)

but that does not seem to trigger a clear error to the user.

I'm no autoconf expert, but I'm guessing moding the above line as follows might do the trick:
AC_CHECK_TOOL(OBJCOPY, objcopy)
if test "x$OBJCOPY" = "x"; then
AC_MSG_ERROR([objcopy from GNU binutils required for gccgo])
fi

@gopherbot gopherbot added this to the Gccgo milestone Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.