Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: command prompts help text improvements #24967

Closed
hnlq715 opened this issue Apr 20, 2018 · 2 comments

Comments

@hnlq715
Copy link

commented Apr 20, 2018

What version of Go are you using (go version)?

v1.10.1

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

amd64

What did you do?

run this command below

vgo vendor -h

What did you expect to see?

usage: vendor
Run 'vgo help vendor' for details.

What did you see instead?

usage: vendor
Run 'go help vendor' for details.

And when I run this command go vendor -h, I get this result below.

go help vendor
Unknown help topic `vendor`. Run 'go help'.

Maybe all vgo command have the same problem.

@agnivade agnivade changed the title vgo's command prompts need improvements x/vgo: command prompts help text improvements Apr 20, 2018

@gopherbot gopherbot added this to the vgo milestone Apr 20, 2018

@oiooj

This comment has been minimized.

Copy link
Member

commented Apr 21, 2018

Even though we are invoking it as vgo, most of the messages printed will still say "go", not "vgo".
Sorry.

@jimmyfrasche

This comment has been minimized.

Copy link
Member

commented Apr 21, 2018

This isn't vgo specific.

I have an alias, gotip, for the devel version of the go tool but it refers to itself as go and not gotip in error messages. If it used os.Args[0] to create the help messages, it would always be correct.

Since vgo is a temporary fork and it's probably not that usual to have multiple versions of the go command unless you work on Go itself, I doubt the effort to fix the root cause would pay off in any meaningful way. But perhaps this is more common than I'm imagining?

@rsc rsc closed this Jun 6, 2018

@golang golang locked and limited conversation to collaborators Jun 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.