Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/crypto: cryptobyte: encode int64 with context-specific tags #24973
We frequently have to deal with asn.1 formatted with context-specific
To do that efficiently with cryptobyte I've added two additional
func (b *Builder) AddInt64(tag asn1.Tag, v int64)
I assume versions for uint64 will also be required.
Does it make sense to add those to the cryptobyte API or is there a workaround?
These are implicitly tagged values, right? (Which is why the existing functions aren't so great?)
If so, then adding some more helper functions seems perfectly reasonable. (Most of the stuff I come across is explicitly tagged, thus I haven't hit this much.)
But I'd name the
I will leave uints until the need arises to keep things simple.
Thanks for the quick response. I've created https://go-review.googlesource.com/c/crypto/+/108456