New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: handle panics in subtests in order to print errors and log info #25021

Open
stephens2424 opened this Issue Apr 23, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@stephens2424

stephens2424 commented Apr 23, 2018

What version of Go are you using (go version)?

1.10.1

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

OS X, Windows, App Engine (playground)

What did you do?

https://play.golang.org/p/4-VN_VdQnrc

What did you expect to see?

I expected to see the error that occurred to be printed, and then the panic.

What did you see instead?

I see only the panic.

The exact use case I have is a table test where each subtest is using a different version of an external resource (message queue). An early subtest fails to perform some setup and leaves an internal thing in a bad state, so I expect my tests to not work fully at this point. However, because the later subtest panics when it encounters that bad state, the whole test function aborts without my previous calls to t.Error or t.Fatal (in the previous subtest) having their contents printed. Because of this, I lost critical error information that would have pointed me to the real issue with the earlier subtest's setup. Since the earlier subtest didn't print anything, its problem was not apparent.

@FiloSottile FiloSottile added this to the Go1.11 milestone Apr 24, 2018

@meirf

This comment has been minimized.

Member

meirf commented May 9, 2018

This behavior has been around since 1.7, which is when subtest support was added.
(That's not to say this behavior is okay - just that it's unlikely there's a recent commit that's causing this.)

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 29, 2018

@ianlancetaylor

This comment has been minimized.

Contributor

ianlancetaylor commented Jun 29, 2018

CC @mpvl

@gopherbot

This comment has been minimized.

gopherbot commented Jul 15, 2018

Change https://golang.org/cl/123921 mentions this issue: testing: handle panics in subtests to print previous output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment