Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: internal compiler error: no function definition for [0xc42181a5a0] [1.10 backport] #25039

Closed
gopherbot opened this issue Apr 24, 2018 · 9 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 24, 2018

@FiloSottile requested issue #23701 to be considered for backport to the next 1.10 minor release.

@gopherbot please open a 1.10 backport tracking issue. We'll need to cherry-pick both CL 92215 by @rsc and CL 104315 by @benesch.

@benesch

This comment has been minimized.

Copy link
Contributor

@benesch benesch commented Apr 24, 2018

Careful. #104315 introduced a bug and I’m not sure @rsc has fixed it yet on master.

@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Apr 24, 2018

@benesch thanks, can you link to (or open) an issue for the introduced bug?

@benesch

This comment has been minimized.

Copy link
Contributor

@benesch benesch commented Apr 24, 2018

I'm not sure if there's an open issue or not. I was only notified by @rsc's comment here: https://go-review.googlesource.com/c/go/+/104315#message-17a7cff9ab15c2e73ca46760c16d0ba4ef5ae502

@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented Apr 27, 2018

@benesch which CLs need to be cherry-picked to fix this issue?

@andybons andybons modified the milestones: Go1.10.2, Go1.10.3 Apr 27, 2018
@benesch

This comment has been minimized.

Copy link
Contributor

@benesch benesch commented Apr 27, 2018

I'm afraid I don't know. My solution in #104315 introduced a bug that @rsc said he'd fix:

FWIW, the code changes and justification here are wrong:
the split must start at pmain, because pmain can depend
on something (say, testing), which depends on p,
and that's not a cycle, but testing must still be
recompiled.

I will fix this as part of some other work I'm doing
in this code.

https://go-review.googlesource.com/c/go/+/104315#message-17a7cff9ab15c2e73ca46760c16d0ba4ef5ae502

As far as I can tell that fix has not yet been committed. I'd be happy to look into fixing it myself but I don't want to duplicate work with @rsc.

@FiloSottile FiloSottile modified the milestones: Go1.10.3, Go1.10.4 Jun 7, 2018
@andybons andybons modified the milestones: Go1.10.4, Go1.10.5 Aug 24, 2018
@katiehockman

This comment has been minimized.

Copy link
Member

@katiehockman katiehockman commented Oct 30, 2018

@FiloSottile Do you still feel that this should be backported? The backport justification didn't include the reason (ie. security issue, serious problem with no workaround).

If so, I'll follow up with @rsc to see if the described issue was resolved.

@dmitshur dmitshur modified the milestones: Go1.10.5, Go1.10.6 Nov 1, 2018
@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Nov 1, 2018

This issue doesn't have sufficient justification for being backported yet, so I moved it to Go 1.10.6 milestone.

@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented Nov 26, 2018

Any update on the backport justification?

@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Nov 26, 2018

I flagged it for backport before we had the discussion about the criteria, and I assumed any regression causing an internal compiler error was worth discussing for backport. 1.11 came out in the meantime, and we agreed "use 1.11" is a valid workaround for cases like this, so closing.

@dmitshur dmitshur modified the milestones: Go1.10.6, Go1.10.7 Dec 13, 2018
@golang golang locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.