Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: share local code inside custom $GOPATH #25053

Closed
gobwas opened this issue Apr 24, 2018 · 3 comments

Comments

@gobwas
Copy link

commented Apr 24, 2018

Hi!

I want to use $GOPATH as a root of git monorepo with several projects sharing some common library:

$ tree
├── Makefile
└── src
       ├── common
       ├── serviceA
       │   └── go.mod
       ├── serviceB 
       │   └── go.mod
       └── v

ServiceA and ServiceB are import some local common/stuff package inside their *.go files. They are also import, say, github.com/some/package with different versions (which are listed in their go.mod files).

How could I use vgo to build serviceA and serviceB separately, with same local code from src/common?

Im trying to compile with script like this:

$ (
  export GOPATH=$(pwd);
  cd src/serviceA;
  vgo build -o ../bin/serviceA;
)

Without any actions I get this error:

vgo: import "serviceA" ->
        import "common/stuff" [/usr/local/go/src/common/stuff]: open /usr/local/go/src/common/stuff: no such file or directory

If I change common to something like common.org:

vgo: import "serviceA" ->
        import "common.org": Get https://common.org?go-get=1: dial tcp: lookup common.org: no such host

Also, If I put something like this into serviceA/go.mod:

replace (
    "common.org" v1.0.0 => "../common"
)

The result is:

vgo: errors parsing go.mod:
<path to src>/src/serviceA/go.mod:6: invalid module version v1.0.0: Get https://common.org?go-get=1: dial tcp: lookup common.org: no such host

Am I doing something wrong, or is this know limitation, or any other suggestion?
Thanks.

@gopherbot gopherbot added this to the vgo milestone Apr 24, 2018

@gobwas gobwas changed the title x/vgo: x/vgo: share local code from custom $GOPATH Apr 24, 2018

@gobwas gobwas changed the title x/vgo: share local code from custom $GOPATH x/vgo: share local code inside custom $GOPATH Apr 24, 2018

@gobwas

This comment has been minimized.

Copy link
Author

commented May 7, 2018

Currently I've found the solution:

Inside the serviceA/go.mod:

module serviceA

replace (
    common v0.0.0 => ../common
)

require (
    common v0.0.0
)

Also, seems like common would not work if it will not look like url, so it must be common.org or something like this (in other way vgo will check $GOROOT dir for such package).

Any way, what is the convenient way to store the v folder in the project repository?

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2018

Sorry for missing this when it came in. The top-level domain problem was real and I believe was fixed. It sounds like you got everything working once you added the require statement. I filed #26241 to try to make that experience better.

Any way, what is the convenient way to store the v folder in the project repository?

I'm not sure what you mean by "the v folder". I see it in the tree output, but I don't know what is in it. If it's like common, then the way is to give it an import prefix.

I want to use $GOPATH as a root of git monorepo with several projects sharing some common library:

I think this is the mismatch. Typically instead of making the monorepo hold all of $GOPATH, you should make the root correspond to some directory like "$GOPATH/src/you.com/myrepo". Then "common" would be at the top level of the repo but imported as "you.com/myrepo/common", and similarly the go.mod would say "module you.com/myrepo/common". And then v would be the same: "module you.com/myrepo/v".

@rsc rsc closed this Jul 6, 2018

@gobwas

This comment has been minimized.

Copy link
Author

commented Jul 9, 2018

Thank you for reply! Will try to use your advice =)

@golang golang locked and limited conversation to collaborators Jul 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.