Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: GithubIssue.NotExist resurrection does not set Created #25060

Open
FiloSottile opened this issue Apr 25, 2018 · 2 comments

Comments

@FiloSottile
Copy link
Member

commented Apr 25, 2018

Noticed while investigating #25031 that in Corpus.processGithubIssueMutation, when an issue is resurrected from NotExist state, its Created field is not set, as that only happens when the issue is first encountered.

No idea when NotExist is set, so not sure if it's an issue, but it looks like that codepath is either unused or broken.

/cc @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Apr 25, 2018

@gopherbot gopherbot added the Builders label Apr 25, 2018

@FiloSottile

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2018

Also by the way there is a comment that says

// Check Updated before all other fields so they don't update if this
// Mutation is stale

but there is no return to implement that behavior.

@dmitshur

This comment has been minimized.

Copy link
Member

commented May 6, 2018

While looking over this issue, I spotted https://go-review.googlesource.com/c/build/+/38137/4/maintner/github.go#456 in processGithubIssueMutation. Despite looking potentially related, I don't think it's actually related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.