x/build: make helper binary wrapper around docker push & kubectl #25283
Comments
Change https://golang.org/cl/112035 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
May 8, 2018
…mmands Updates golang/go#25283 Change-Id: Ic8a3c03d803a561d836d24737eb0baaa965172e3 Reviewed-on: https://go-review.googlesource.com/112035 Reviewed-by: Andrew Bonventre <andybons@golang.org>
I did more in https://go-review.googlesource.com/c/build/+/113135 |
Sufficiently done. We can add more over time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Our Makefiles in x/build make it too easy to screw up, since they assume hidden gcloud & kubectl & docker state.
I just spent hours debugging a
docker push
auth issue (finally resolved with help of gcr.io team), and then I screwed up a deploy due to:Note that
deploy-staging
rule doesn't validate that mykubectl
is in the right cluster/context.I'm going to fix this with a helper Go program around all these such operations that can additionally verify things are correct.
Likewise with the various gcloud commands.
/cc @andybons @FiloSottile @bcmills
The text was updated successfully, but these errors were encountered: