Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Our Makefiles in x/build make it too easy to screw up, since they assume hidden gcloud & kubectl & docker state.
I just spent hours debugging a docker push auth issue (finally resolved with help of gcr.io team), and then I screwed up a deploy due to:
kubectl set image deployment/coordinator-deployment coordinator=$(IMAGE_PROD):$(VERSION)
kubectl set image deployment/coordinator-deployment coordinator=$(IMAGE_STAGING):$(VERSION)
Note that deploy-staging rule doesn't validate that my kubectl is in the right cluster/context.
I'm going to fix this with a helper Go program around all these such operations that can additionally verify things are correct.
Likewise with the various gcloud commands.
/cc @andybons @FiloSottile @bcmills
The text was updated successfully, but these errors were encountered:
Change https://golang.org/cl/112035 mentions this issue: cmd/xb: add new safety command to double-check state of deployment commands
cmd/xb: add new safety command to double-check state of deployment commands
Sorry, something went wrong.
cmd/xb: add new safety command to double-check state of deployment co…
Reviewed-by: Andrew Bonventre <firstname.lastname@example.org>
I did more in https://go-review.googlesource.com/c/build/+/113135
Sufficiently done. We can add more over time.
No branches or pull requests