Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: make helper binary wrapper around docker push & kubectl #25283

Closed
bradfitz opened this issue May 7, 2018 · 3 comments
Closed

x/build: make helper binary wrapper around docker push & kubectl #25283

bradfitz opened this issue May 7, 2018 · 3 comments
Assignees
@bradfitz
Labels
Builders FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 7, 2018

Our Makefiles in x/build make it too easy to screw up, since they assume hidden gcloud & kubectl & docker state.

I just spent hours debugging a docker push auth issue (finally resolved with help of gcr.io team), and then I screwed up a deploy due to:

deploy-prod: push-prod
        kubectl set image deployment/coordinator-deployment coordinator=$(IMAGE_PROD):$(VERSION)
deploy-staging: push-staging
        kubectl set image deployment/coordinator-deployment coordinator=$(IMAGE_STAGING):$(VERSION)

Note that deploy-staging rule doesn't validate that my kubectl is in the right cluster/context.

I'm going to fix this with a helper Go program around all these such operations that can additionally verify things are correct.

Likewise with the various gcloud commands.

/cc @andybons @FiloSottile @bcmills
@bradfitz bradfitz self-assigned this May 7, 2018
@gopherbot gopherbot added this to the Unreleased milestone May 7, 2018
@gopherbot gopherbot added the Builders label May 7, 2018
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented May 8, 2018

Change https://golang.org/cl/112035 mentions this issue: cmd/xb: add new safety command to double-check state of deployment commands
gopherbot pushed a commit to golang/build that referenced this issue May 8, 2018
@bradfitz
cmd/xb: add new safety command to double-check state of deployment co…
5e39b3d 
…mmands

Updates golang/go#25283

Change-Id: Ic8a3c03d803a561d836d24737eb0baaa965172e3
Reviewed-on: https://go-review.googlesource.com/112035
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@bradfitz bradfitz commented May 22, 2018

I did more in https://go-review.googlesource.com/c/build/+/113135
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@bradfitz bradfitz commented Jun 11, 2018

Sufficiently done. We can add more over time.
@bradfitz bradfitz closed this Jun 11, 2018
@golang golang locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradfitz bradfitz

Labels
Builders FrozenDueToAge
Projects
None yet
Milestone
  Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bradfitz @gopherbot
You can’t perform that action at this time.