New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: bundle invocation without -dst is fragile #25285

Open
FiloSottile opened this Issue May 8, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@FiloSottile
Member

FiloSottile commented May 8, 2018

The bundle invocation in the net/http go:generate for h2 does not have a -dst flag. So it breaks when bundle was not built with the toolchain associated with the target net/http package, as the embedded GOROOT is wrong. When developing the standard library it's fairly common[citation needed] to use a different system compiler to go get binaries, so it's probably worth adding -dst at the next run.

/cc @bradfitz

@FiloSottile FiloSottile added this to the Go1.11 milestone May 8, 2018

@bradfitz

This comment has been minimized.

Member

bradfitz commented May 8, 2018

I'm inclined to say that you're holding it wrong.

That tool has had approximately 1-2 users. Now maybe 1-3. I don't think it's worth the effort changing the tool to be more accommodating to more (uncommon?) configurations.

But if you want to, all yours.

@bradfitz bradfitz modified the milestones: Go1.11, Unreleased May 8, 2018

@bradfitz

This comment has been minimized.

Member

bradfitz commented May 8, 2018

Definitely not a Go 1.11 blocker by any means.

@FiloSottile

This comment has been minimized.

Member

FiloSottile commented May 8, 2018

The tool already has the feature, this is only here to remember to add -dst net/http next time one of us runs it, as it did not feel worth of its own CL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment