Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: use expandable columns in ssa.html? #25286

Closed
josharian opened this issue May 8, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@josharian
Copy link
Contributor

commented May 8, 2018

As the number of SSA passes has grown, ssa.html has gotten wider and thus harder to navigate. I'd like to float the idea of having the initial display show just a few columns, with the others be expandable stubs (with names). As to the initial list of columns, maybe something like: start, after early deadcode, after opt, after lower, after late deadcode, after regalloc, genssa.

There's also the question of whether this can be reasonably implemented in standalone javascript, a question about which I know little.

Opinions?

cc @dr2chase @randall77 @cherrymui

@josharian josharian added this to the Unplanned milestone May 8, 2018

@randall77

This comment has been minimized.

Copy link
Contributor

commented May 8, 2018

Yes, please.
It is not possible that your javascript knowledge is less than mine.

@ALTree ALTree added NeedsFix and removed NeedsDecision labels May 8, 2018

@ysmolsky

This comment has been minimized.

Copy link
Member

commented Jun 7, 2018

@josharian is it okay when you reload ssa.html [in a browser] you would get to default state of collapsed columns?

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2018

Yes. It’d be nice to do some saved local state or query params, but as a first pass, I think always reverting to the default is fine. In the normal case I imagine the reader will be interested in one or two columns at most, so restoring state manually isn’t that big a deal.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 7, 2018

Change https://golang.org/cl/117275 mentions this issue: cmd/compile: use expandable columns in ssa.html

@ysmolsky ysmolsky self-assigned this Jun 8, 2018

@ysmolsky

This comment has been minimized.

Copy link
Member

commented Jun 11, 2018

In case if you want to give a feedback without downloading the patch above:

screen shot 2018-06-12 at 00 12 42

screen shot 2018-06-12 at 00 13 50

The vertical text (a column) can be expanded by clicking on it. If you want something else, just let me know.

I would be glad to help because I learned a thing or two about SSA while making the change. Also I would like to implement some of the TODOs buired in ssa.go regarding graphic representation (nodes->ssa?) or maybe just dumping the log from ssa to the ssa.html, so file can be shared as standalone piece.
/cc @josharian

EDITED: typos and formatting

@gopherbot gopherbot closed this in 5eb98b3 Jun 13, 2018

dna2github added a commit to dna2fork/go that referenced this issue Jun 14, 2018

cmd/compile: use expandable columns in ssa.html
Display just a few columns in ssa.html, other
columns can be expanded by clicking on collapsed column.

Use sans serif font for the text, slightly smaller font size
for non program text.

Fixes golang#25286

Change-Id: I1094695135401602d90b97b69e42f6dda05871a2
Reviewed-on: https://go-review.googlesource.com/117275
Run-TryBot: Yury Smolsky <yury@smolsky.by>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.