Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: upgrade FreeBSD builders to avoid flakes #25289
FreeBSD people, is it reasonable to take down our 10.3 and 11.1 builders and replace them with 10.4 or 11.2? I'd rather not double the number of FreeBSD builder's we're running, but we could if necessary. I don't know what versions are important/commonly used in practice.
Use freebsd-update when preparing the downloaded -RELEASE image to get errata and security updates made since the release. Switch kern.timecounter.hardware from ACPI-safe to TSC on GCE https://lists.freebsd.org/pipermail/freebsd-cloud/2017-January/000080.html Drop vtnet hw.vtnet.csum_disable=1 workaround, should be fixed in all supported versions. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207446 Update the expect script to switch the console to serial, this makes it possible to match prompts via a regexp (11.2 has 'root@freebsd:~ #', while the older images are 'root@:~ #'). Otherwise qemu with -display curses emits ansi escape codes which make a mess of everything. This requires the sgabios smbios extension installed on the host preparing the images. https://code.google.com/archive/p/sgabios/ https://packages.ubuntu.com/xenial/sgabios SeaBIOS 1.11.0 and up should have a compatible rom builtin, but it's not even available in Ubuntu 18.04. qemu/seabios@d6728f3 Additionaly drop the -smp 2 directive for qemu, until MTTCG is enabled on amd64 targets. Updates golang/go#25289 Change-Id: If33c2b35b4221f27d719938bcfc013efe3549305 Reviewed-on: https://go-review.googlesource.com/135475 Reviewed-by: Brad Fitzpatrick <email@example.com>
@bradfitz our builders are horribly out of date, for eg. our 11.1 builder is 11.1-RELEASE and is missing around a year worth of security patches and updates (~15 of them).
Unfortunately 11.1 is expected to receive EoL on the 30th of September, and 10.4 a month after that.
I think we have no choice but to switch the 10.3-RELEASE to 10.4-RELEASE-p13. Maybe it's worth while having a 11.1 builder as well, but I'd rather we update it to 11.1-RELEASE-p15 if we'd need to test future Go 1.10/1.11 releases?
Since 10.4 and 11.2 are currently supported releases (even though they're close to EoL), I think it is reasonable to bump up the revs used by the builders.
It may also be helpful to start eyeing a 12.0 builder since it is due in Novemberish.
It looks like there are a few system call/ABI changes in 12 that might need addressing. I wonder how incompatibilities across GOOS versions are handled. It might be useful to be able to target FreeBSD 11.x and FreeBSD 12.x as separate GOOS.
Not yet the defaults or trybots until we see they're working regularly for a few days and compare timings, etc. Updates golang/go#25289 Change-Id: I4baed066b5f6d9f01e5454b716cacda4986620d0 Reviewed-on: https://go-review.googlesource.com/138258 Reviewed-by: Yuval Pavel Zholkover <firstname.lastname@example.org> Reviewed-by: Dmitri Shuralyov <email@example.com>
Install GDB from the ports collection, the in-tree was removed from the base system in FreeBSD 12.0, and the older releases have an unsupported (6.1.1 or older version). Updates golang/go#25289 Change-Id: I8899a2a70c0b9ee9171621206431ca24a7e97704 Reviewed-on: https://go-review.googlesource.com/c/155977 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>