New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go test cmd/go (without -short) may be failing on Windows #25300

Open
neolit123 opened this Issue May 8, 2018 · 4 comments

Comments

Projects
None yet
6 participants
@neolit123
Contributor

neolit123 commented May 8, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version devel +e0adc35c Tue May 8 21:15:48 2018 +0000 windows/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

>go env

set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Lubo\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\Lubo\go
set GORACE=
set GOROOT=c:\dev\go
set GOTMPDIR=
set GOTOOLDIR=c:\dev\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Windows\T
EMP\go-build598151490=/tmp/go-build -gno-record-gcc-switches

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

> go test cmd/go -v

cmd/go passes when doing:

src/all.cmd

or:

go test -short -v cmd/go

What did you expect to see?

passing tests for cmd/go.

What did you see instead?

https://gist.githubusercontent.com/neolit123/b48fc27c8be1eb598fb41ce3cb2366f4/raw/06c1e91e076206574f4136a72aa238c3b1df878d/gistfile1.txt

with an older version i used to see this:

*** Test killed: ran too long (10m0s).

full log here:
https://pastebin.com/XNNAKhBW

requested by:
@alexbrainman

refs:
#24709

@ianlancetaylor

This comment has been minimized.

Contributor

ianlancetaylor commented May 8, 2018

Using src/all.cmd will run go test -test.short cmd/go. What happens if you run go test -short -v cmd/go? That is, is the problem due to adding -v, or is it due to omitting -short?

@neolit123

This comment has been minimized.

Contributor

neolit123 commented May 8, 2018

Using src/all.cmd will run go test -test.short cmd/go. What happens if you run go test -short -v cmd/go? That is, is the problem due to adding -v, or is it due to omitting -short?

@ianlancetaylor

the test seems to pass using -short -v:
https://pastebin.com/ah1Jp8rn

let me know if you need me to debug a specific test.

@bradfitz bradfitz removed the OS-Windows label Jun 20, 2018

@bradfitz bradfitz changed the title from cmd/go: failed tests on win32 to cmd/go: full tests can take longer than 3 minutes (especially on Windows) Jun 20, 2018

@bradfitz bradfitz added the NeedsFix label Jun 20, 2018

@bradfitz bradfitz modified the milestones: Go1.11, Go1.12 Jun 20, 2018

@bcmills bcmills added the Testing label Oct 25, 2018

@rsc

This comment has been minimized.

Contributor

rsc commented Oct 25, 2018

It looks from the transcript in the link that there are some failing tests in non-short mode. Unfortunately, that's true, or at least was in May.

I don't see anything in the initial report about a 3-minute failure. Not sure why Brad put that in the title.

@rsc rsc changed the title from cmd/go: full tests can take longer than 3 minutes (especially on Windows) to cmd/go: go test cmd/go (without -short) may be failing on Windows Oct 25, 2018

@neolit123

This comment has been minimized.

Contributor

neolit123 commented Oct 26, 2018

updated and rebuild latest master:

go version devel +43530e6b Fri Oct 26 12:37:30 2018 +0000 windows/amd64

go env is same as OP.

go test cmd/go -v

https://gist.githubusercontent.com/neolit123/b48fc27c8be1eb598fb41ce3cb2366f4/raw/8dc9a4c812cc5a6e81c03112768083735afa15ac/october%25202018%2520run%25201

i ran the tests a 3-4 times and it seems to fail at a different location each time.

it prompts for github login in one of the tests and if one does not enters right away it can fail with a:
*** Test killed: ran too long (10m0s). error once.`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment