New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/salsa20: implement cipher.Stream interface #25308

Open
FiloSottile opened this Issue May 9, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@FiloSottile
Copy link
Member

FiloSottile commented May 9, 2018

salsa20 is the odd one out that implements only a stateless XORKeyStream at the package level.

@FiloSottile FiloSottile added this to the Unreleased milestone May 9, 2018

@as

This comment has been minimized.

Copy link
Contributor

as commented May 11, 2018

The nonce is currently exposed to the user, how would the cipher.Stream interface modify the nonce? simple increment?

How does the constructor handle the semantics for the different salsa lengths?

@jannson

This comment has been minimized.

Copy link

jannson commented Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment