Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/cryptotest: new package #25309

Open
FiloSottile opened this issue May 9, 2018 · 2 comments
Open

x/crypto/cryptotest: new package #25309

FiloSottile opened this issue May 9, 2018 · 2 comments

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented May 9, 2018

crypto/cipher has well defined interfaces with plenty of tricky requirements (about aliasing, different lengths, state) that are hard to test for and easy to overlook.

cryptotest will be an interface test suite, like nettest. It caught a bug in x/crypto/internal/chacha20 and can replace a bunch of duplicated tests in the standard library, too.

It's useful to expose it in x/crypto for external implementations of the interface to use it. It will be vendored back.

Originally submitted as an internal package in https://golang.org/cl/102196

@gopherbot gopherbot added this to the Proposal milestone May 9, 2018
@gopherbot gopherbot added the Proposal label May 9, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented May 9, 2018

Change https://golang.org/cl/112315 mentions this issue: cryptotest: new package

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jul 16, 2018

Sounds fine to us.

@bradfitz bradfitz modified the milestones: Proposal, Unplanned Jul 16, 2018
@bradfitz bradfitz added the NeedsFix label Jul 16, 2018
@bradfitz bradfitz changed the title proposal: x/crypto/cryptotest: new package x/crypto/cryptotest: new package Jul 16, 2018
@FiloSottile FiloSottile modified the milestones: Unplanned, Unreleased Dec 3, 2019
@FiloSottile FiloSottile removed the Proposal label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.