Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
In e0adc35 test/gcgort.go is added. This test may benefit from being generated instead of hand-written to increase maintainability by reducing repeating and narrow test coverage by removing extraneous setup code like the modifier struct.
This change would be after 1.11 and my opinion is it should only be done if the test strategy is also updated for the stated garbage collector, types, and concurrency interactions coverage. Currently the test failure relies on the runtime implementation causing a panic.
@burakguven The way to generate is new to me and looks like a good step forward. Even so there’s still a lot of code for the generate program because of the templates.
Ideally the test would catch issues without the runtime having to panic. I was thinking something like verifying that the memory of