Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: vgo tool cover still wants project in GOPATH #25318

Closed
jlabath opened this issue May 9, 2018 · 2 comments

Comments

@jlabath
Copy link

commented May 9, 2018

What version of Go are you using (go version)?

go version go1.10.2 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"

What did you do?

vgo test ./... -v -coverprofile=coverage.out [OK]
vgo tool cover -func=coverage.out [FAIL]

What did you expect to see?

coverage report

What did you see instead?

        /opt/local/lib/go/src/github.com/gadventures/attributor/config (from $GOROOT)
        /compass/gocode/src/github.com/gadventures/attributor/config (from $GOPATH)

Which makes sense because my project is not in the GOPATH - however vgo test works just fine - so I suspect it's just caused by vgo being new and vgo tool cover needing some love.

Thanks

@gopherbot gopherbot added this to the vgo milestone May 9, 2018

@utrack

This comment has been minimized.

Copy link

commented Jun 4, 2018

Still relevant.

@gopherbot

This comment has been minimized.

Copy link

commented Jul 6, 2018

Change https://golang.org/cl/122478 mentions this issue: cmd/cover: invoke go command to find packages

@gopherbot gopherbot closed this in fd263cc Jul 10, 2018

@golang golang locked and limited conversation to collaborators Jul 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.