Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/cache: remove $GOCACHE/log.txt #25323

Closed
mattn opened this Issue May 10, 2018 · 7 comments

Comments

Projects
None yet
8 participants
@mattn
Copy link
Member

mattn commented May 10, 2018

In my $GOCACHE, file size of my log.txt is 5.7MB. Current implementation doesn't take care the size of log.txt. Some environment possibly have more large log file. How about to add a way to remove or rotating log file?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented May 10, 2018

CC @rsc

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 14, 2018

@japettyjohn

This comment has been minimized.

Copy link

japettyjohn commented Nov 5, 2018

I can confirm the possibility of a large file - I ran into one being 12 gigs and stretching back 4 months. This could be addressed either in the go clean -cache routine in clean.go or added as another flag there, e.g. go clean -cacheLog.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 21, 2018

Change https://golang.org/cl/150797 mentions this issue: cmd/go/internal/cache: remove cache logs if -cacheLog flag is set

@FiloSottile

This comment has been minimized.

Copy link
Member

FiloSottile commented Jan 2, 2019

Mine is 451M, while the rest of the cache is 20M. I think we should limit its size automatically, not only when a specific "go clean" command is run.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Jan 7, 2019

It's pretty late to add new command line flags to cmd/go.

Bumping to Go 1.13.

@bradfitz bradfitz modified the milestones: Go1.12, Go1.13 Jan 7, 2019

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Jan 8, 2019

We added this file in order to help evaluate the automatic cache expiry policy. It was important for that purpose that go clean not delete it. But I think we're quite happy with the automatic cache expiry policy - certainly no one has complained - so I think we can just stop writing the file and also delete it during go clean -cache. But for Go 1.13, not Go 1.12. Thanks.

@gopherbot gopherbot removed the NeedsDecision label Jan 8, 2019

@FiloSottile FiloSottile changed the title cmd/go/internal/cache: remove old logs in $GOCACHE/log.txt cmd/go/internal/cache: remove $GOCACHE/log.txt Jan 8, 2019

@bcmills bcmills self-assigned this Mar 15, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 15, 2019

Change https://golang.org/cl/167741 mentions this issue: cmd/go/internal/cache: remove log.txt from the cache directory

@gopherbot gopherbot closed this in 37e4a61 Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.